messageList: Don't include message actor in error message

Because the message actor could also be undefined or a already
deallocated ClutterActor, we sometimes fail to show the error message
and get an error from Gjs instead.

So make sure we always log the proper error message and just leave out
the actor.

https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/833

diff --git a/js/ui/messageList.js b/js/ui/messageList.js
index 08bcbb4449e482f668a7dbe739c0cc1b6f6843e0..3188d0377fa67fd512a6deb67cd624ebfc328220 100644 (file)
--- a/js/ui/messageList.js
+++ b/js/ui/messageList.js
@@ -642,7 +642,7 @@ var MessageListSection = GObject.registerClass({
 
     moveMessage(message, index, animate) {
         if (!this._messages.includes(message))
-            throw new Error(`Impossible to move the untracked message ${message}`);
+            throw new Error(`Impossible to move untracked message`);
 
         let listItem = message.get_parent();
 
@@ -671,7 +671,7 @@ var MessageListSection = GObject.registerClass({
 
     removeMessage(message, animate) {
         if (!this._messages.includes(message))
-            throw new Error(`Impossible to remove the untracked message ${message}`);
+            throw new Error(`Impossible to remove untracked message`);
 
         let listItem = message.get_parent();
         listItem._connectionsIds.forEach(id => message.disconnect(id));